chabala commented on PR #32:
URL: 
https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769067418

   > > So it looks like when we use includes/excludes fastDelete will not works 
- correct?
   > 
   > Yes and it makes sense. The fast delete moves the entire directory. If you 
want to delete only some files, you cannot move the directory because the files 
that should stay there would not.
   
   I agree. Looks like fast delete has always required `GlobSelector` to be 
null, since it was added in #6. So, it has never worked for this `Fileset` 
parsing path, only the directory parsing path above it at: 
https://github.com/apache/maven-clean-plugin/blob/f9da326e1b1ad4648d24e646b51cc7bc0a1baad7/src/main/java/org/apache/maven/plugins/clean/CleanMojo.java#L250-L254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to