[
https://issues.apache.org/jira/browse/MNG-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783040#comment-17783040
]
ASF GitHub Bot commented on MNG-5695:
-------------------------------------
hboutemy commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382636597
##########
maven-plugin-tools-annotations/src/site/apt/index.apt:
##########
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent component;
+ // pseudo-parameters (marked read-only) permitting injection of Maven
build context objects
// sample objects taken from Maven API through
PluginParameterExpressionEvaluator
+ //
https://maven.apache.org/ref/current/maven-core/apidocs/org/apache/maven/plugin/PluginParameterExpressionEvaluator.html
+ // plugins targetting Maven 3.2.5+ (after MNG-5695) should not use these
pseudo-parameters any more,
+ // but @Component and Maven APIs to get better compiler-time checks
- @Parameter( defaultValue = "${session}", readonly = true )
+ // @Parameter( defaultValue = "${session}", readonly = true )
+ @Component // since Maven 3.2.5, thanks to MNG-5695
Review Comment:
so do we all now agree that using `@Component` is better than using
`@Parameter( defaultValue = "${session}", readonly = true )` (because smaller
and moreover we're sure there is no typo in the default value expression)?
if we agree, the warning could be to promote switch to `@Component`...
> inconsistent custom Guice scope bindings
> ----------------------------------------
>
> Key: MNG-5695
> URL: https://issues.apache.org/jira/browse/MNG-5695
> Project: Maven
> Issue Type: Bug
> Reporter: Igor Fedorenko
> Assignee: igorfie
> Priority: Major
> Fix For: 3.2.5
>
>
> - Session scope ({{MavenSession}}) is only available for maven core and core
> extensions components (i.e. -Dmaven.ext.class.path stuff), but does not work
> for components from maven plugins.
> - Mojo execution scope ({{MavenProject}} and {{MojoExecution}}) works for
> components from maven plugins but not for maven core and core extensions.
> Need to consistently bind custom Guice scopes in all realms.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
