[ 
https://issues.apache.org/jira/browse/MCOMPILER-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789331#comment-17789331
 ] 

Herve Boutemy commented on MCOMPILER-542:
-----------------------------------------

you're right, I was hard with "hack", workaround is better :)
{quote}I could add the info message on every modification (even if I would 
prefer as debug).
{quote}
too chatty: that's why I proposed just a single summary at the end of the 
patch, to know that the patch was activated and how much it had to patch. More 
detail, even in debug, is too much noise IMHO

and the objective to know that the patch was activated is to also see in the 
future that it's not activated any more, and eventually that it's activated but 
did not find anything to patch...

> clean JDK patch version in module-info.class
> --------------------------------------------
>
>                 Key: MCOMPILER-542
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-542
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.11.0
>            Reporter: Herve Boutemy
>            Assignee: Herve Boutemy
>            Priority: Major
>             Fix For: 3.12.0
>
>
> as seen in MJAR-275, JDK patch version in module-info.class is NOT included 
> only when building with a newer JDK release using "--release" flag, see 
> [https://github.com/jvm-repo-rebuild/module-info]
> issue [https://bugs.openjdk.org/browse/JDK-8318913] created in JDK to get a 
> proper fix at javac level (probably for Java 22)
> and waiting for that, we need a workaround to drop the JDK patch version in 
> other cases: we'll need to define where is the best place – 
> m-jar-p?m-compiler-p? other?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to