Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

[via GitHub]

olamy commented on code in PR #181:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404817131


##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1539,36 +1546,41 @@ private static List<String> 
removeEmptyCompileSourceRoots(List<String> compileSo
      * generated classes and if we got a file which is &gt;= the build-started 
timestamp, then we caught a file which
      * got changed during this build.
      *
-     * @return <code>true</code> if at least one single dependency has changed.
+     * @return {@code true} if at least one single dependency has changed.
      */
-    protected boolean isDependencyChanged() {
-        if (session == null) {
+    private boolean isDependencyChanged() {

Review Comment:
   same comment as here 
https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404816887



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org