[ 
https://issues.apache.org/jira/browse/MNG-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790539#comment-17790539
 ] 

ASF GitHub Bot commented on MNG-7945:
-------------------------------------

elharo commented on code in PR #1323:
URL: https://github.com/apache/maven/pull/1323#discussion_r1407684809


##########
maven-core/src/main/java/org/apache/maven/internal/transformation/TransformedArtifact.java:
##########
@@ -38,7 +38,11 @@
  */
 abstract class TransformedArtifact extends DefaultArtifact {
 
-    private final OnChangeTransformer onChangeTransformer;
+    interface Transformer {
+        Path transform() throws Exception;

Review Comment:
   I'm not yet convinced that a full java.lang.Exception is desirable here. 
Possibly an IOException if it's writing/reading files. Possibly no exception at 
all should be allowed. 





> Fix profile settings being injected into consumer POMs
> ------------------------------------------------------
>
>                 Key: MNG-7945
>                 URL: https://issues.apache.org/jira/browse/MNG-7945
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 4.0.0-alpha-8
>            Reporter: Tamas Cservenak
>            Assignee: Guillaume Nodet
>            Priority: Major
>             Fix For: 4.0.0-alpha-9
>
>
> The consumer POMs may end up containing information from user settings.
> The reason is that they are currently built from the effective POMs.  They 
> need to be rebuilt based on raw models.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to