[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793828#comment-17793828 ]
ASF GitHub Bot commented on MCOMPILER-381: ------------------------------------------ jorsol commented on PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#issuecomment-1843238062 Well, I think this should be ready to be merged if there is no other comment. BTW, looking at the open issues, this should also fix [MCOMPILER-333](https://issues.apache.org/jira/browse/MCOMPILER-333) so it can be linked to this and declare it fixed for 3.12.0 > Refactoring needed for isDependencyChanged / Using fileExtensions > (AbstractCompilerMojo) > ---------------------------------------------------------------------------------------- > > Key: MCOMPILER-381 > URL: https://issues.apache.org/jira/browse/MCOMPILER-381 > Project: Maven Compiler Plugin > Issue Type: Improvement > Affects Versions: 3.8.1 > Reporter: Karl Heinz Marbaise > Priority: Minor > Fix For: 3.12.0 > > > The code in the class AbstractCompilerMojo has a method > {{isDependencyChanged}} which uses the attribute {{fileExtensions}} which is > being changed within the {{isDependencyChanged}} method. This attribute is > also being used by the method {{hasNewFile}} which is a kind of confusing (a > control via a global variable). > Furthermore a change in {{isDependencyChanged}} where replacing {{".class"}} > with {{"class"}} results in a [fail which is described here|MCOMPILER-379]. > It should be investigated how this code can be made more clear and maybe > easier to understand. -- This message was sent by Atlassian Jira (v8.20.10#820010)