rmannibucau commented on code in PR #1336:
URL: https://github.com/apache/maven/pull/1336#discussion_r1418926148
##########
maven-core/src/main/resources/META-INF/maven/extension.xml:
##########
@@ -187,6 +189,7 @@ under the License.
<exportedArtifact>org.apache.maven.resolver:maven-resolver-util</exportedArtifact>
<exportedArtifact>org.apache.maven.resolver:maven-resolver-connector-basic</exportedArtifact>
+ <exportedArtifact>jakarta.inject:jakarta.inject-api</exportedArtifact>
Review Comment:
:thinking: I don't see why:
* injections in mojo are already bridged
* abstracting injection markers (with a maven inject annotation) is easy in
guice
* abstracting the injector or a lookup (like we had/have in plexus
container) is quite trivial
* abstracting a scope is not crazy (wayless than what we already have)
So overall, even if I'm not sure which case(s) you want to cover, I don't
see a reason to break our original hypotheis to define a clean and maven owned
API and export anything jakarta related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
