elharo commented on code in PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#discussion_r1420408887


##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##########
@@ -189,20 +190,44 @@ public void filterResources(MavenResourcesExecution 
mavenResourcesExecution) thr
             // as destination
             // see MNG-1345
             File outputDirectory = 
mavenResourcesExecution.getOutputDirectory();
-            boolean outputExists = outputDirectory.exists();
-            if (!outputExists && !outputDirectory.mkdirs()) {
+            if (!outputDirectory.mkdirs() && !outputDirectory.exists()) {
                 throw new MavenFilteringException("Cannot create resource 
output directory: " + outputDirectory);
             }
 
             if (resource.isFiltering()) {
                 isFilteringUsed = true;
             }
 
-            boolean ignoreDelta = !outputExists
-                    || 
buildContext.hasDelta(mavenResourcesExecution.getFileFilters())
-                    || 
buildContext.hasDelta(getRelativeOutputDirectory(mavenResourcesExecution));
-            LOGGER.debug("ignoreDelta " + ignoreDelta);
-            Scanner scanner = buildContext.newScanner(resourceDirectory, 
ignoreDelta);
+            boolean filtersFileChanges = 
buildContext.hasDelta(mavenResourcesExecution.getFileFilters());

Review Comment:
   filtersFileChanged?  since "changes" sounds like it's the actual changes 
instead of a boolean indicating whether things changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to