[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794697#comment-17794697 ]
ASF GitHub Bot commented on MSHARED-1285: ----------------------------------------- elharo commented on code in PR #77: URL: https://github.com/apache/maven-filtering/pull/77#discussion_r1420408887 ########## src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java: ########## @@ -189,20 +190,44 @@ public void filterResources(MavenResourcesExecution mavenResourcesExecution) thr // as destination // see MNG-1345 File outputDirectory = mavenResourcesExecution.getOutputDirectory(); - boolean outputExists = outputDirectory.exists(); - if (!outputExists && !outputDirectory.mkdirs()) { + if (!outputDirectory.mkdirs() && !outputDirectory.exists()) { throw new MavenFilteringException("Cannot create resource output directory: " + outputDirectory); } if (resource.isFiltering()) { isFilteringUsed = true; } - boolean ignoreDelta = !outputExists - || buildContext.hasDelta(mavenResourcesExecution.getFileFilters()) - || buildContext.hasDelta(getRelativeOutputDirectory(mavenResourcesExecution)); - LOGGER.debug("ignoreDelta " + ignoreDelta); - Scanner scanner = buildContext.newScanner(resourceDirectory, ignoreDelta); + boolean filtersFileChanges = buildContext.hasDelta(mavenResourcesExecution.getFileFilters()); Review Comment: filtersFileChanged? since "changes" sounds like it's the actual changes instead of a boolean indicating whether things changed > DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes > ------------------------------------------------------------------------------ > > Key: MSHARED-1285 > URL: https://issues.apache.org/jira/browse/MSHARED-1285 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-filtering > Reporter: Christoph Läubrich > Priority: Major > > The maven resources plugin uses > [https://github.com/apache/maven-filtering/blob/master/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java] > to copy resources, but that component has some subtile flaws reported here: > [https://github.com/eclipse-m2e/m2e-core/discussions/1468] > The problematic part is the usage of BuildContext#newScanner that already > mentions in the javadoc that passing ignoreDelta to neScanner might not > reveal all required items +*for copy-resources*+ form A -> B and instead > BuildContext#isUpTodate should be used. > Just from a quick look I assume that part of code actually wants to use > something like this: > {code:java} > DirectoryScanner ds = new DirectoryScanner() { > @Override > protected boolean isSelected(String name, File file) { > if (file.isFile() && buildContext.isUptodate(getTargetFile(file), file)) > { > return false; > } > return true; > } > }; > ds.setBasedir(basedir); {code} > That way all the code that currently checks for if output directory existed > before can also be removed what is another issue because it leads to a full > resources copy even if source+target are already even if a single class file > is changed while the idea seems more that if the output was not there it > should not try to be incremental! -- This message was sent by Atlassian Jira (v8.20.10#820010)