cstamas commented on code in PR #337:
URL: https://github.com/apache/maven-indexer/pull/337#discussion_r1425947320
##########
pom.xml:
##########
@@ -94,8 +94,7 @@ under the License.
<properties>
<javaVersion>11</javaVersion>
- <maven.compiler.source>${javaVersion}</maven.compiler.source>
- <maven.compiler.target>${javaVersion}</maven.compiler.target>
+ <maven.compiler.release>${javaVersion}</maven.compiler.release>
Review Comment:
Bah, forgot that this should not be removed :smile:
Due this in parent:
https://github.com/apache/maven-parent/blob/maven-parent-41/pom.xml#L956-L957
Hence 11 becomes "1.11", which is kinda fine so far (as javac will ignore
those two when release set), but reporting craps out, so release becomes
impossible. Will undo this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
