[ 
https://issues.apache.org/jira/browse/MNG-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800360#comment-17800360
 ] 

ASF GitHub Bot commented on MNG-5695:
-------------------------------------

michael-o commented on PR #236:
URL: 
https://github.com/apache/maven-plugin-tools/pull/236#issuecomment-1869096681

   > We also should remove replacements and worning form code:
   > 
   > 
https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java#L791
   > 
   > changing only documentation users will be confused when use it
   
   Right, it needs to be consistent. @cstamas, your turn.




> inconsistent custom Guice scope bindings
> ----------------------------------------
>
>                 Key: MNG-5695
>                 URL: https://issues.apache.org/jira/browse/MNG-5695
>             Project: Maven
>          Issue Type: Bug
>            Reporter: Igor Fedorenko
>            Assignee: igorfie
>            Priority: Major
>             Fix For: 3.2.5
>
>
> - Session scope ({{MavenSession}}) is only available for maven core and core 
> extensions components (i.e. -Dmaven.ext.class.path stuff), but does not work 
> for components from maven plugins.
> - Mojo execution scope ({{MavenProject}} and {{MojoExecution}}) works for 
> components from maven plugins but not for maven core and core extensions.
> Need to consistently bind custom Guice scopes in all realms.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to