[
https://issues.apache.org/jira/browse/MSHARED-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801468#comment-17801468
]
ASF GitHub Bot commented on MSHARED-1347:
-----------------------------------------
elharo commented on code in PR #102:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/102#discussion_r1438922443
##########
src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java:
##########
@@ -157,4 +160,14 @@ private void addTypeSignature(final String signature) {
new SignatureReader(signature).acceptType(signatureVisitor);
}
}
+
+ @Override
+ public void visitInvokeDynamicInsn(
Review Comment:
Insn --> Instruction
I had to think about this one to figure it out.
In general, avoid abbreviations
##########
src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ASMDependencyAnalyzerTest.java:
##########
@@ -40,4 +43,12 @@ void test() throws Exception {
assertThat(result).isNotEmpty();
}
+
+ @Test
+ void verify_implicit_class_reference_included_in_used_classes() throws
IOException {
Review Comment:
naming convention seems wonky here
> maven-dependency-plugin ignores class of object passed as a parameter to
> method references
> ------------------------------------------------------------------------------------------
>
> Key: MSHARED-1347
> URL: https://issues.apache.org/jira/browse/MSHARED-1347
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-dependency-analyzer
> Affects Versions: maven-dependency-analyzer-1.13.2
> Reporter: Vidar Breivik
> Priority: Minor
>
> Text copied from [MDEP-576|https://issues.apache.org/jira/browse/MDEP-576]
> Hi there, i created a project on
> [github|https://github.com/vdergachev/dependency-plugin-vs-java-lambda] that
> can help you to reproduce the issue. Just clone it and make
> {code:java}
> mvn clean install{code}
> In my case plugin ignored Server class from jetty-server.jar and a as result
> i got message
> {code:java}
> Unused declared dependencies found{code}
>
> h4.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
