michael-o commented on code in PR #207:
URL:
https://github.com/apache/maven-invoker-plugin/pull/207#discussion_r1439085173
##########
pom.xml:
##########
@@ -62,12 +62,13 @@ under the License.
<properties>
<javaVersion>8</javaVersion>
- <mavenVersion>3.2.5</mavenVersion>
+ <mavenMinVersion>3.2.5</mavenMinVersion>
+ <mavenVersion>3.9.6</mavenVersion>
Review Comment:
I wouldn't do this either in this release.
##########
pom.xml:
##########
@@ -169,6 +183,12 @@ under the License.
<groupId>org.apache.maven.doxia</groupId>
<artifactId>doxia-sink-api</artifactId>
<version>1.12.0</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-container-default</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Fair enough, will be solved with Doxia 2.0.0.
##########
pom.xml:
##########
@@ -145,6 +146,19 @@ under the License.
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.maven.resolver</groupId>
+ <artifactId>maven-resolver-api</artifactId>
+ <version>1.9.18</version>
+ <scope>provided</scope>
Review Comment:
This does not correspond to the approach we have taken in other plugins: Use
the same Resolver API version as with the base Maven Core version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
