[
https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802294#comment-17802294
]
ASF GitHub Bot commented on MNG-6776:
-------------------------------------
slawekjaranowski commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440780384
##########
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##########
@@ -51,9 +52,7 @@ public class MojoDescriptor extends ComponentDescriptor<Mojo>
implements Cloneab
private static final String DEFAULT_LANGUAGE = "java";
- private List<Parameter> parameters;
-
- private Map<String, Parameter> parameterMap;
+ private final ArrayList<Parameter> parameters;
Review Comment:
Can be `List` type?
> Inconsistent list of parameters in MojoDescriptor
> -------------------------------------------------
>
> Key: MNG-6776
> URL: https://issues.apache.org/jira/browse/MNG-6776
> Project: Maven
> Issue Type: Bug
> Components: Plugin API
> Affects Versions: 3.6.2
> Reporter: Sylwester Lachiewicz
> Assignee: Tamas Cservenak
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While working with maven-plugin-tools I discovered inconsistent results
> returned from MojoDescriptor getParameters() and getParametersMap().
> In
> [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101]
> If first I call MojoDescriptor.getParameterMap() and then later add parameter
> via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still
> return map with old (cached) list with parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
