yurloc commented on code in PR #489: URL: https://github.com/apache/maven-site/pull/489#discussion_r1467552884
########## content/apt/guides/mini/guide-reproducible-builds.apt: ########## @@ -78,7 +78,10 @@ mvn clean verify artifact:compare [] - Notice that this does NOT really prove that your build is yet reproducible, because your build may still suffer from environment leaks (username, current directory, ...). But it is easy to do, and prevents basic non-reproducible issues like timestamps. + Notice that this does NOT really prove that your build is yet reproducible, because your build may still suffer from environment leaks (username, current directory, ...). + Also not that it might suffer from false positives. Libraries included in your build might not support reproducible builds themselves but at the same time produce reproducible artifacts. Review Comment: If that is true and we could remove it then the false-positive failure of `artifact:check-buildplan` would disappear and so would the confusion and this paragraph wouldn't need any update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
