[
https://issues.apache.org/jira/browse/MASSEMBLY-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814113#comment-17814113
]
ASF GitHub Bot commented on MASSEMBLY-967:
------------------------------------------
slawekjaranowski opened a new pull request, #183:
URL: https://github.com/apache/maven-assembly-plugin/pull/183
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> maven-assembly-plugin doesn't add target/class artifacts in generated jarfat
> but META-INF/MANIFEST.MF seems to be correct
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: MASSEMBLY-967
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-967
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: maven-archiver
> Affects Versions: 3.3.0, 3.4.0
> Environment: MacOS Catalina and others Linux flavours
> Reporter: João Antonio Ferreira
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: 3.7.0
>
>
> See below the relevant build segment extracted from pom.xml:
> {code:xml}
> <plugin>
> <artifactId>maven-assembly-plugin</artifactId>
> <version>3.4.0</version>
> <configuration>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> <mainClass>my_package.Main</mainClass>
> </manifest>
> </archive>
> <descriptorRefs>
> <descriptorRef>jar-with-dependencies</descriptorRef>
> </descriptorRefs>
> </configuration>
> </plugin>
> {code}
> this command below does not show anything
> {code:bash}
> jar -tvf target/my-fat-jar.jar | grep Main.class
> {code}
> My main class and other project artifacts are not added in fatjar by
> maven-assembly-plugin
> *Edit:* I tested it with other versions of the plugin (3.2.0, 2.2, ...) and
> it didn't work. However if I change the version from 3.4.0 to *2.2-beta-5 the
> fatjar is generated correctly*. Version 2.2-beta-5 is from 12/06/2009, ie
> very old. I would like to use a newer version. Any idea ?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
