desruisseaux commented on PR #1378:
URL: https://github.com/apache/maven/pull/1378#issuecomment-1925933959
Added Javadoc on shortcut methods in `Session` interface. Sometime I had to
guess, and there is questions previously flagged by `@todo` tag in b72d1ce. The
test case gives the impression that the answer to those questions is that the
dependency given in argument is included in the returned list, but it would be
nice to said that in the javadoc if it is the case.
Added a convenience method:
```java
@Nonnull
Map<PathType, List<Path>> resolveDependencies(
@Nonnull DependencyCoordinate dependencyCoordinate,
@Nonnull PathScope scope,
@Nonnull Collection<PathType> desiredTypes);
```
Expanded an existing test case: after fetching the dependency paths, fetch
again the same dependency paths but this time dispatched by type.
* First invoke above convenience method with
`Arrays.asList(JavaPathType.CLASSES, JavaPathType.MODULES)`:
* The `pom` dependency is excluded, because it is placed neither on the
class-path or module-path.
* The `junit` dependency appears on the module-path because it has as
`Automatic-Module-Name` attribute.
* All other dependencies are on the class-path.
* Invoke the same method again, but this time with only
`Arrays.asList(JavaPathType.CLASSES)`:
* The `junit` dependency is now on the class-path.
* This is the mechanism by which a plugin can tell that it is not
interested in JPMS.
**Note:** A test if failing in the "Maven Core ITs suite" module:
```
Error: MavenITmng5135AggregatorDepResolutionModuleExtensionTest.testit:61-
AbstractMavenIntegrationTestCase.assertTrue:359 [test-classes, classes]
==> expected: <true> but was: <false>
```
I don't know what is happening here. A search for
`AbstractMavenIntegrationTestCase` in my repository clone found nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
