[
https://issues.apache.org/jira/browse/MWRAPPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814433#comment-17814433
]
ASF GitHub Bot commented on MWRAPPER-112:
-----------------------------------------
inkarkat commented on PR #102:
URL: https://github.com/apache/maven-wrapper/pull/102#issuecomment-1927412123
Alright, I've sent the signed ICLA to the secretary email address (I was
under the impression that this change of < 20 lines and basically just
deletions didn't require one).
May I also draw your attention to #106 - the second PR from me that fixes
another issue in the wrapper scripts?! I've just freshly rebased that one.
> Detection of JAVA_HOME fails due to bad quoting
> -----------------------------------------------
>
> Key: MWRAPPER-112
> URL: https://issues.apache.org/jira/browse/MWRAPPER-112
> Project: Maven Wrapper
> Issue Type: Bug
> Affects Versions: 3.2.0, 3.3.0
> Environment: Ubuntu 20.04, Java 17
> Reporter: Ingo Karkat
> Assignee: Benjamin Marwell
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.3.0
>
>
> I have a standard Ubuntu 20.04 Java installation ({{{}openjdk-17-jdk{}}} APT
> package, {{/usr/bin/javac}} linked to
> {{/usr/lib/jvm/java-17-openjdk-amd64/bin/javac}} via the update-alternatives
> system, no {{JAVA_HOME}} set). Maven Wrapper 3.2.0 should detect that, but on
> each invocation prints this warning:
> {{Warning: JAVA_HOME environment variable is not set.}}
> This is caused by excessive quoting (i.e. the {{{}\"{}}}):
> {{javaExecutable="$(readlink -f "\"$javaExecutable\"")"}}
> Apparently, that code has been in the codebase since the beginning, taken
> over from the {{gradlew}} wrapper (which had the shell wrappers completely
> rewritten; there are no remnants of this code found there any longer).
> Pull request: https://github.com/apache/maven-wrapper/pull/102
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
