[
https://issues.apache.org/jira/browse/MWRAPPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816309#comment-17816309
]
Alexander Schwartz commented on MWRAPPER-91:
--------------------------------------------
Hi, at that time, we used mvnw with the script that then downloaded the JAR
file of the wrapper as we didn't commit that to our repo. At the time, I didn't
know about the script-only wrapper.
I migrated one of the projects [I'm working
for|https://github.com/keycloak/keycloak/issues/23047] to the shell-only
wrapper and it resolved for me the issue where `MAVEN_ARGS` where not supported
by the other option - see MWRAPPER-110
I suppose the `only-mvnw` has a similar problem as it is writing directly to
the file, instead of first downloading the file and then moving the file to the
to final name after a successful download, see
https://github.com/apache/maven-wrapper/blob/master/maven-wrapper-distribution/src/resources/only-mvnw#L202
> Concurrent execution of mvnw to download wrapper fails
> ------------------------------------------------------
>
> Key: MWRAPPER-91
> URL: https://issues.apache.org/jira/browse/MWRAPPER-91
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
> Affects Versions: 3.1.0
> Reporter: Alexander Schwartz
> Assignee: Benjamin Marwell
> Priority: Major
>
> The script will download the executable maven wrapper JAR file directly to
> the final file name.
> When multiple calls do this concurrently, it happens that the first call
> executes the JAR file that is currently overwritten by the second parallel
> call.
> This leads to error like:
> * {{NoClassDefFoundError: org/codehaus/plexus/PlexusContainer}}
> * {{ClassNotFoundException: org.apache.maven.wrapper.MavenWrapperMain}}
> A different solution might be to first download the JAR file to a temporary
> file, and then use an atomic file operator like a rename one the download is
> complete.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
