[
https://issues.apache.org/jira/browse/MNG-8059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819250#comment-17819250
]
ASF GitHub Bot commented on MNG-8059:
-------------------------------------
cstamas commented on code in PR #1413:
URL: https://github.com/apache/maven/pull/1413#discussion_r1497563860
##########
maven-builder-support/src/main/java/org/apache/maven/building/UrlSource.java:
##########
@@ -87,6 +87,6 @@ public boolean equals(Object obj) {
}
UrlSource other = (UrlSource) obj;
- return this.url.equals(other.url);
+ return Objects.equals(url.toExternalForm(),
other.url.toExternalForm());
Review Comment:
url equality check performs hostname resolution
> Move Resolver off java.io.File to NIO2 Paths
> --------------------------------------------
>
> Key: MNG-8059
> URL: https://issues.apache.org/jira/browse/MNG-8059
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Followup of MRESOLVER-496
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
