[ 
https://issues.apache.org/jira/browse/MARTIFACT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832073#comment-17832073
 ] 

ASF GitHub Bot commented on MARTIFACT-59:
-----------------------------------------

rmannibucau commented on PR #30:
URL: 
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2026810271

   I updated the description, an external reference is 
https://github.com/yupiik/tools-maven-plugin/pull/12 but long story short it is 
`<project.build.outputTimestamp>${git.commit.time}</project.build.outputTimestamp>`
 like usages.
   
   I thought about your position to say it is wrong to not hardcode it, if this 
PR is really not an option, I think I could "not care" about it if the value is 
automatically rewritten by a plugin.
   I'm not yet sure of the best plugin for that - artifact looks wrong, 
git-commit-id too, spotless or pom rewriters don't know about last change date 
so not yet fixed on where.
   
   Would it be better for you?




> artifact plugin should tolerate injected project.build.outputTimestamp
> ----------------------------------------------------------------------
>
>                 Key: MARTIFACT-59
>                 URL: https://issues.apache.org/jira/browse/MARTIFACT-59
>             Project: Maven Artifact Plugin
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>            Priority: Minor
>              Labels: pull-request-available
>
> Goal is to not log
> {code:java}
> Reproducible Build not activated by project.build.outputTimestamp property: 
> see https://maven.apache.org/guides/mini/guide-reproducible-builds.html {code}
> when the project is actually set but computed from another property and not 
> fail (check mojo) when the setup is the same.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to