rmannibucau commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2030278980
> wrong, they use everything, and it works: I still don't get what needs to be changed in maven-artifact-plugin wrong (ok was cause it made me smile to read it) please just run `buildinfo` goal and you'll get in the parent - as explained in my comment: > [WARNING] Reproducible Build not activated by project.build.outputTimestamp property: see https://maven.apache.org/guides/mini/guide-reproducible-builds.html Which is *not* a "it works as expected" behavior for me. My setup with git-commit-id works similarly but a warning in the build is just a sign it is buggy by design and there it is technically justifiable too. Now, as mentionned, run `mvn artifact:check-buildplan` and you get - still in the parent but you get it: > [ERROR] Reproducible Build not activated by project.build.outputTimestamp property: see https://maven.apache.org/guides/mini/guide-reproducible-builds.html and a nice > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-artifact-plugin:3.5.0:check-buildplan (default-cli) on project moditect-parent: non-reproducible plugin or configuration found with fix available -> [Help 1] which breaks the build. So no, it does not work for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
