[ 
https://issues.apache.org/jira/browse/MCOMPILER-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839822#comment-17839822
 ] 

ASF GitHub Bot commented on MCOMPILER-515:
------------------------------------------

hunterpayne commented on PR #160:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2070683052

   Incremental building is an important feature.  If you need it, you need it.  
Most projects don't but some very important projects do and they need something 
like this the most.  I think the right solution is a compromise where we scale 
back how this works.  The problem is that computing the right set of code to 
recompile is hard.  So let's just make that part easy.  
   
   Perhaps make the incremental based upon something higher level that where we 
are now.  If that's not possible, then the solution is to actually maintain a 
map of files to classes to dependent classes/files from the last build and to 
use that to compute what is built.  I think that is the buggy part as that that 
map is hard to maintain.  Perhaps make that map manually editable by devs.  We 
only need this feature in dev environments anyway.
   
   TLDR This is an important feature so let's find a way to reduce the 
complexity to make it work and be maintainable.




> Plugin is NOT incremental, so let it go
> ---------------------------------------
>
>                 Key: MCOMPILER-515
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-515
>             Project: Maven Compiler Plugin
>          Issue Type: Bug
>            Reporter: Tamas Cservenak
>            Priority: Major
>
> The maven-compiler-plugin is NOT incremental, so we should just let it go. 
> The shared incremental stuff is broken since it's last factual code change 
> (2012!).
> Moreover, the broken incremental stuff just makes us look bad, see the "mvn 
> clean install" vs "mvn verify" issue: 
> [https://www.youtube.com/watch?v=XeQj-IbSxJI]
> Accept it, that this plugins is not incremental, so it should not make users 
> believe it is. Moreover, the bugs in this feature exist for too long, that 
> just cause harm to users and to project as whole.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to