[ https://issues.apache.org/jira/browse/MBUILDCACHE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839854#comment-17839854 ]
ASF GitHub Bot commented on MBUILDCACHE-88: ------------------------------------------- kbuntrock opened a new pull request, #147: URL: https://github.com/apache/maven-build-cache-extension/pull/147 The project tests cannot be run on a jdk21. See : https://issues.apache.org/jira/browse/MBUILDCACHE-88 Please not that this fix does not address the comment line 123 of `CacheConfigImplTest.class` : `// unfortunate and potentially fragile deep mocking, but helps avoid most disk involvement while working around // the static nio Files.exists method` The mock implementation can still be considered as fragile. -------------------------------------------------------------- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [MBUILDCACHE JIRA issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Tests in failure when ran on jdk21 > ---------------------------------- > > Key: MBUILDCACHE-88 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-88 > Project: Maven Build Cache Extension > Issue Type: Bug > Affects Versions: 1.1.0 > Reporter: Kevin Buntrock > Priority: Minor > > The project tests cannot be run on jdk21. Result is : > {code:java} > [INFO] > [INFO] Results: > [INFO] > [ERROR] Failures: > [ERROR] CacheConfigImplTest.testInitializationDisabledInXML:234 expected: > <DISABLED> but was: <INITIALIZED> > [ERROR] > CacheConfigImplTest.testRemoteDisableByUserPropertyOverride:330->assertDefaults:137->assertDefaults:201->lambda$testRemoteDisableByUserPropertyOverride$39:330 > expected: <dummy.url.xyz> but was: <null> > [ERROR] > CacheConfigImplTest.testRemoteEnableByUserPropertyOverrideWithURL:313->assertDefaults:137->assertDefaults:201->lambda$testRemoteEnableByUserPropertyOverrideWithURL$38:315 > expected: <true> but was: <false> > [ERROR] > CacheConfigImplTest.testRemoteEnableInXMLWithURL:288->assertDefaults:137->assertDefaults:201->lambda$testRemoteEnableInXMLWithURL$36:290 > expected: <true> but was: <false> > [ERROR] > CacheConfigImplTest.testRemoteSaveIgnoredWhenRemoteDisabledByUserPropertyOverride:420->assertDefaults:137->assertDefaults:201->lambda$testRemoteSaveIgnoredWhenRemoteDisabledByUserPropertyOverride$48:420 > expected: <dummy.url.xyz> but was: <null> > [ERROR] > CacheConfigImplTest.testRemoveSaveDisabledByUserProperty:381->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveDisabledByUserProperty$47:383 > expected: <true> but was: <false> > [ERROR] > CacheConfigImplTest.testRemoveSaveEnabledByUserProperty:362->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveEnabledByUserProperty$45:365 > expected: <true> but was: <false> > [ERROR] > CacheConfigImplTest.testRemoveSaveEnabledInXML:344->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveEnabledInXML$42:347 > expected: <true> but was: <false> > [ERROR] > CacheConfigImplTest.testRemoveSaveFinalEnabledByUserProperty:436->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveFinalEnabledByUserProperty$51:439 > expected: <true> but was: <false> > [ERROR] > CacheConfigImplTest.testRemoveSaveFinalIgnoredWhenRemoteSaveDisabled:455->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveFinalIgnoredWhenRemoteSaveDisabled$54:457 > expected: <true> but was: <false> > [INFO] > [ERROR] Tests run: 71, Failures: 10, Errors: 0, Skipped: 4 > [INFO] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------{code} > In class "CacheConfigImplTest", a method "deepMockConfigFile" mocks the > result of the call to java.nio.file.Files.exists (via > "FileSystemProvider.checkAccess"). > In jdk21 version, "Files.exists" does not rely on the same underlying > "FileSystemProvider" method, therefore breaking the mocking purpose. -- This message was sent by Atlassian Jira (v8.20.10#820010)