lrozenblyum commented on code in PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#discussion_r1586330276
##########
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##########
@@ -299,6 +299,33 @@ public void testShouldSetUpdateSnapshotsFlagFromRequest() {
assertArgumentsPresent(cli, Collections.singleton("-U"));
}
+ // JUnit5: test methods don't need to be public
Review Comment:
Actually the `test` prefix is also redundant for `@Test` methods, yet here I
kept the project-wide convention...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
