[
https://issues.apache.org/jira/browse/MWRAPPER-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845698#comment-17845698
]
ASF GitHub Bot commented on MWRAPPER-139:
-----------------------------------------
ascopes opened a new pull request, #139:
URL: https://github.com/apache/maven-wrapper/pull/139
MWRAPPER-139: Remove trailing whitespace from fields in
maven-wrapper.properties
This prevents issues due to confusion between CRLF and LF when running in
more exotic locations such as MINGW on Windows but using ./mvnw rather than
./mvnw.cmd. A prime example of where this is an issue would be on
windows-latest GitHub Actions runners.
Fixes MWRAPPER-139, MWRAPPER-137 (which I didn't spot for some reason when
reviewing the
existing tickets on JIRA... might have been a blip in JIRA that didn't
display it?).
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
> Shell scripts break on LF in config for Windows
> -----------------------------------------------
>
> Key: MWRAPPER-139
> URL: https://issues.apache.org/jira/browse/MWRAPPER-139
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
> Affects Versions: 3.3.1
> Reporter: Ashley Scopes
> Priority: Major
>
> Today, I updated the Maven Wrapper in a project I have on GitHub by running
> `./mvnw wrapper:wrapper`, and then pushed it to GitHub.
> It appears that upon doing this, the bash scripts no longer work due to how
> newlines are being interpreted in the maven-wrapper.properties file.
> {code}
> + ./mvnw --version
> distributionUrl is not valid, must match *-bin.zip or maven-mvnd-*.zip, but
> found
> 'https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.6/apache-maven-3.9.6-bin.zip
> '
> {code}
> This appears to just affect when running on GitHub actions with a Windows
> runner and the `bash` shell.
> I will see if I can find the issue and raise a fix in an MR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
