[
https://issues.apache.org/jira/browse/MJAR-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847517#comment-17847517
]
ASF GitHub Bot commented on MJAR-310:
-------------------------------------
slawekjaranowski opened a new pull request, #87:
URL: https://github.com/apache/maven-jar-plugin/pull/87
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAR) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MJAR-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAR-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> [REGRESSION] Plugin fails to handle toolchain paths that contain spaces
> -----------------------------------------------------------------------
>
> Key: MJAR-310
> URL: https://issues.apache.org/jira/browse/MJAR-310
> Project: Maven JAR Plugin
> Issue Type: Bug
> Affects Versions: 3.4.0, 3.4.1
> Environment: Maven 3.9.6
> Windows 10
> Reporter: Gili
> Priority: Major
> Fix For: next-release
>
>
> When upgrading from version 3.3.0 to 3.4.0 I started getting the following
> build-time warning:
>
> {{[WARNING] Unrecognized output form C:\Program
> Files\Java\zulu-8\bin\javac.exe -version - 'C:\Program' is not recognized as
> an internal or external command,}}
> {{operable program or batch file.}}
>
> The contents of toolchain.xml is:
>
> {{<?xml version="1.0" encoding="UTF8"?>}}
> {{<toolchains>}}
> {{ <toolchain>}}
> {{ <type>jdk</type>}}
> {{ <provides>}}
> {{ <version>8</version>}}
> {{ <vendor>zulu</vendor>}}
> {{ </provides>}}
> {{ <configuration>}}
> {{ <jdkHome>C:\Program Files\Java\zulu-8</jdkHome>}}
> {{ </configuration>}}
> {{ </toolchain>}}
> {{</toolchains>}}
>
> I don't know if this warning breaks anything.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
