[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849965#comment-17849965
]
ASF GitHub Bot commented on MSHADE-478:
---------------------------------------
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616976316
##########
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##########
@@ -444,6 +474,17 @@ public void execute() throws MojoExecutionException {
artifacts.add(project.getArtifact().getFile());
+ if (extraJars != null && !extraJars.isEmpty()) {
+ for (File extraJar : extraJars) {
+ if (!Files.isRegularFile(extraJar.toPath())) {
+ createErrorOutput();
Review Comment:
```java
private void createErrorOutput() {
getLog().error("The project main artifact does not exist. This could
have the following");
getLog().error("reasons:");
....
```
> Add ability to inject extra artifacts into shaded output
> --------------------------------------------------------
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
