michael-o commented on code in PR #244:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/244#discussion_r1621995663


##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1239,7 +1239,9 @@ public void execute() throws MojoExecutionException, 
CompilationFailureException
             }
         }
 
-        if (outputTimestamp != null && (outputTimestamp.length() > 1 || 
Character.isDigit(outputTimestamp.charAt(0)))) {
+        if (outputTimestamp != null
+                && !outputTimestamp.isEmpty()

Review Comment:
   I'd like to understand how the value can be empty: `<foo/>`? This basically 
can happen in any plugin using this value, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to