[ https://issues.apache.org/jira/browse/MPLUGIN-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851005#comment-17851005 ]
ASF GitHub Bot commented on MPLUGIN-508: ---------------------------------------- gnodet commented on code in PR #286: URL: https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1622016198 ########## maven-plugin-report-plugin/src/it/mplugin-319_report-since/src/main/java/org/MyMojo.java: ########## @@ -19,41 +19,32 @@ package org; import org.apache.maven.plugin.AbstractMojo; +import org.apache.maven.plugins.annotations.Mojo; +import org.apache.maven.plugins.annotations.Parameter; /** * Does nothing. * - * @goal noop - * @phase process-sources - * @requiresDependencyResolution test - * @requiresDirectInvocation true - * @requiresOnline - * @inheritByDefault false - * @execute phase="compile" - * @aggregator * @since 1.0 * * @deprecated You don't use test goals, do you? */ +@Mojo(name = "noop") public class MyMojo extends AbstractMojo { Review Comment: Why ? if not specified, the plugin won't have a default phase, but that's not a problem here. We don't even use this plugin, we're only building it. > Upgrade to Maven 4.x > -------------------- > > Key: MPLUGIN-508 > URL: https://issues.apache.org/jira/browse/MPLUGIN-508 > Project: Maven Plugin Tools > Issue Type: New Feature > Affects Versions: 3.12.0 > Reporter: Guillaume Nodet > Assignee: Guillaume Nodet > Priority: Major > Fix For: 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)