[ 
https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851408#comment-17851408
 ] 

ASF GitHub Bot commented on MPIR-451:
-------------------------------------

elharo commented on code in PR #67:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/67#discussion_r1623397208


##########
src/main/resources/project-info-reports_fr.properties:
##########
@@ -117,8 +117,8 @@ report.dependency-convergence.stats.readyrelease.success    
       = Succ\u00e8s
 report.dependency-convergence.stats.snapshots                      = Nombre 
d'artefacts SNAPSHOT (NOS)\u202f:
 report.dependency-convergence.stats.modules                        = Nombre de 
sous-projets\u202f:
 report.dependency-convergence.title                                = 
R\u00e9action de la convergence des d\u00e9pendances
-report.dependency-info.name                                        = 
Informations de d\u00e9pendance
-report.dependency-info.title                                       = 
Informations de d\u00e9pendance
+report.dependency-info.name                                        = 
Coordonnu00e9es de Maven

Review Comment:
   I think you're missing a backslash before \u00e9 here and in the next line



##########
src/site/apt/index.apt.vm:
##########
@@ -79,6 +79,17 @@ ${project.name}
 
    * {{{./summary-mojo.html}project-info-reports:summary}} is used to generate 
the Project Summary report.
 
+* Upcoming Incompatibility Notice
+
+  With the next major version (4.0) mojos and output filenames will change for 
consistency alignment

Review Comment:
   period at end



##########
src/site/apt/index.apt.vm:
##########
@@ -44,8 +44,8 @@ ${project.name}
    * 
{{{./dependency-convergence-mojo.html}project-info-reports:dependency-convergence}}
 is used to generate the
    Project Dependency Convergence report for (reactor) builds.
 
-   * {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is 
used to generate code snippets to
-   be added to build tools.
+   * {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is 
used to generate code snippets

Review Comment:
   is used to generate --> generates



##########
src/site/apt/index.apt.vm:
##########
@@ -79,6 +79,17 @@ ${project.name}
 
    * {{{./summary-mojo.html}project-info-reports:summary}} is used to generate 
the Project Summary report.
 
+* Upcoming Incompatibility Notice
+
+  With the next major version (4.0) mojos and output filenames will change for 
consistency alignment
+  To make you aware of that, see the following table for the upcoming changes:

Review Comment:
   Might drop "To make you aware of that,"





> Rename "Dependency Information" to "Maven Coordinates"
> ------------------------------------------------------
>
>                 Key: MPIR-451
>                 URL: https://issues.apache.org/jira/browse/MPIR-451
>             Project: Maven Project Info Reports Plugin
>          Issue Type: Improvement
>            Reporter: Elliotte Rusty Harold
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.6.0
>
>
> From a thread on commons-math where I noticed I was unable to find the Maven 
> coordinates for the project on the project's website:
> The only way to get to that page is scroll about two thirds of the way down a 
> sidebar and click one of the four links that mention "dependencies" that 
> seems as likely to bring you to a list of commons-math's own dependencies 
> rather than how to add this project as a dependency. I'm a Maven comitter 
> who's spent way more time in the depths of Maven Project website generation 
> than 99.9% of Java programmers and I still couldn't find this the first time 
> I looked for it. That's de facto evidence that this information is not easy 
> to find.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to