[ 
https://issues.apache.org/jira/browse/MPLUGIN-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852523#comment-17852523
 ] 

Keegan Witt edited comment on MPLUGIN-504 at 6/5/24 6:04 PM:
-------------------------------------------------------------

I came across this issue trying to understand how to fix my build. The 
[documentation|https://maven.apache.org/plugin-tools/maven-plugin-plugin/examples/generate-help.html]
 still has

{code:xml}
<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-plugin-plugin</artifactId>
  <version>3.13.1</version>
  <executions>
    <execution>
      <id>generated-helpmojo</id>
      <goals>
        <goal>helpmojo</goal>
      </goals>
    </execution>
  </executions>
</plugin>
{code}

Which is exactly what my build still has. At the moment, I still don't 
understand what I need to do. I've tried {{<goal>plugin:helpmojo</goal>}} and 
{{<goal>maven-plugin-plugin:helpmojo</goal>}} and 
{{<goal>org.apache.maven.plugins:maven-plugin-plugin:helpmojo</goal>}}. None of 
these work.


was (Author: keegan):
I came across this issue trying to understand how to fix my build. The 
[documentation|https://maven.apache.org/plugin-tools/maven-plugin-plugin/examples/generate-help.html]
 still has

{code:xml}
<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-plugin-plugin</artifactId>
  <version>3.13.1</version>
  <executions>
    <execution>
      <id>generated-helpmojo</id>
      <goals>
        <goal>helpmojo</goal>
      </goals>
    </execution>
  </executions>
</plugin>
{code}

Which is exactly what my build still has. At the moment, I still don't 
understand what I need to do.

> [regression] Goal prefix is required now
> ----------------------------------------
>
>                 Key: MPLUGIN-504
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-504
>             Project: Maven Plugin Tools
>          Issue Type: Bug
>            Reporter: Christoph Läubrich
>            Priority: Major
>
> With https://issues.apache.org/jira/browse/MPLUGIN-450 there was a regression 
> introduced that leads to previous working builds fail if the have not 
> configured a goalprefix, the error message is:
> >  You need to specify a goalPrefix as it can not be correctly computed
> This has several issues:
> # It does not explain why one "needs" a goalPrefix, nor what it is useful for 
> or why it can not be correctly computed.
> # It is effectively a breaking change in a minor version increment
> # The inital JIRA mentions that
> a) in general, goal prefix is *+optional+*, but "good to have", and usually 
> is present.
> b) we may want to have some option to turn off this feature
> # Now it is required and there is no option to turn it off
> Also the message is not true, the plugin has successfully computed a prefix 
> before without any issues:
> * If the artifact ends with -maven-plugin as in my-cool-maven-plugin the 
> my-cool was chosen
> * If the artifact ends with -plugin as in my-cool-plugin the my-cool was 
> chosen
> * otherwise the full artifact if was chosen as a prefix as in my-cool the 
> my-cool was chosen
> From a users point of view I don't see any problem or "disambiguates" with 
> this approach that justifies a breaking change here, anyone who is concerned 
> about not using this default can and already could choose a prefix and seem 
> to been fine with it for a long time.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to