[
https://issues.apache.org/jira/browse/SUREFIRE-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2250:
-------------------------------------
Summary: Surefire Test Report Schema properties element is not consistent
with the code (was: Surefire Test Report Schema element properties is not
consistent with the code)
> Surefire Test Report Schema properties element is not consistent with the code
> ------------------------------------------------------------------------------
>
> Key: SUREFIRE-2250
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2250
> Project: Maven Surefire
> Issue Type: Bug
> Components: xml generation
> Affects Versions: 3.3.0
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.3.1
>
>
> surefire-test-report.xsd defines:
> {code:xml}
> <xs:element name="properties" minOccurs="0" maxOccurs="unbounded">
> {code}
> but the Java code says:
> {code}
> private static void showProperties(XMLWriter xmlWriter, Map<String,
> String> systemProperties) throws IOException {
> xmlWriter.startElement("properties");
> for (final Entry<String, String> entry : systemProperties.entrySet())
> {
> final String key = entry.getKey();
> String value = entry.getValue();
> if (value == null) {
> value = "null";
> }
> xmlWriter.startElement("property");
> xmlWriter.addAttribute("name", key);
> xmlWriter.addAttribute("value", extraEscapeAttribute(value));
> xmlWriter.endElement();
> }
> xmlWriter.endElement();
> }
> {code}
> and is called only once in
> {{org.apache.maven.plugin.surefire.report.StatelessXmlReporter.testSetCompleted(WrappedReportEntry,
> TestSetStats)}}. This makes the schema definition wrong. Let's fix this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
