[
https://issues.apache.org/jira/browse/MJARSIGNER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863544#comment-17863544
]
ASF GitHub Bot commented on MJARSIGNER-76:
------------------------------------------
slachiewicz commented on code in PR #20:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/20#discussion_r1667633959
##########
src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java:
##########
@@ -346,6 +350,23 @@ private List<File> findJarfiles() throws
MojoExecutionException {
return archives;
}
+ /**
+ * {@linkplain Path#relativize(Path) Relativizes} the path against {@link
MavenProject#getBasedir()}.
+ * Can be used to shorten or simplify paths before displaying them to the
user.
+ */
+ private Path relativizePathAgainstBasedir(Path path) {
Review Comment:
This will not have best performance, as You calculate base dir for every file
> Print names of processed files
> ------------------------------
>
> Key: MJARSIGNER-76
> URL: https://issues.apache.org/jira/browse/MJARSIGNER-76
> Project: Maven Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Marcono1234
> Priority: Minor
>
> h2. Problem
> Currently the plugin just prints the number of processed artifacts once it is
> done, for example:
> {quote}
> 2 archive(s) processed
> {quote}
> This has these disadvantages:
> - It is not immediately obvious if the intended file has been signed (e.g.
> when using wildcards)
> - If the number is higher than expected, it is not obvious which additional
> files were signed redundantly
> In both cases it is necessary to manually inspect the artifacts of the
> project and check if they have been signed (or use {{jarsigner}} to verify
> them).
> h2. Improvement
> By default the plugin should print the file names of the signed artifacts.
> This information is already available in {{AbstractJarsignerMojo#execute}},
> but currently only {{archives.size()}} is logged.
> - Ideally each file should be logged in a separate line to be easier to read.
> - The relative file path (and not only the file name) should be logged.
> Otherwise there might be confusion if the same file exists in multiple
> directories, e.g. if it is copied by another plugin during the build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
