Marcono1234 commented on code in PR #46:
URL:
https://github.com/apache/maven-gh-actions-shared/pull/46#discussion_r1673141637
##########
.github/workflows/maven-verify.yml:
##########
@@ -199,7 +212,8 @@ jobs:
name: ${{ matrix.os }} jdk-${{ matrix.jdk }}-${{ matrix.distribution }}
timeout-minutes: ${{ inputs.timeout-minutes }}
runs-on: ${{ matrix.os }}
-
+ if: always() && ( !inputs.ff-run || needs.fail-fast-build.result ==
'success' )
Review Comment:
It seems this `if: always()` here has the unfortunate side effect that it is
impossible to cancel the workflow, see
https://github.com/orgs/community/discussions/26303. That is quite problematic
because once the matrix starts, you have potentially dozens of long running
uncancelable jobs.
As suggested in that discussion, maybe `!cancelled()` could be an
alternative to `always()` here?
What was the intention for `if: always()`? Note that there is already
`strategy.fail-fast` being set below.
Sorry for commenting on this old PR, but since this introduced it
originally, I hope that is ok.
Edit: Have created #108 now, proposing to replace the `if: always()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
