[
https://issues.apache.org/jira/browse/MPLUGIN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872924#comment-17872924
]
ASF GitHub Bot commented on MPLUGIN-530:
----------------------------------------
kwin commented on PR #1638:
URL: https://github.com/apache/maven/pull/1638#issuecomment-2283943537
> So if you're targeting master, I'm not sure this PR is really needed.
We are somehow going in cycles with this PR:
@gnodet I think we agreed that even for Plugin Descriptor v2 the
`requirements` is still evaluated! That means it should be marked as deprecated
in both 1.1 and 2.0! I am gonna fix the version in this PR as well for
`requirements`, but you should go over all other elements as well!
Regarding
> the deprecation message is plain wrong (mvn4 API has DI annotation, and
not JSR330 is to be used)
I am gonna clarify that in the deprecation that this is not necessarily JSR
330 annotation but alternatively some other annotation evaluated at run time.
> Am unsure is this PR really needed.
For me the plugin descriptor is the primary contract between a plugin and
Maven, and therefore it needs to be formally deprecated there before we can
ultimately get rid of it in the future!
> Deprecate o.a.m.plugins.annotations.Component
> ---------------------------------------------
>
> Key: MPLUGIN-530
> URL: https://issues.apache.org/jira/browse/MPLUGIN-530
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: maven-plugin-annotations
> Affects Versions: 3.13.1, 4.0.0-beta-1
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Labels: plugin-descriptor-1.1
>
> The annotation
> [{{org.apache.maven.plugin.plugins.annotations.Component}}|https://maven.apache.org/plugin-tools/maven-plugin-annotations/apidocs/org/apache/maven/plugins/annotations/Component.html]
> should be deprecated in favour of [JSR 330
> annotations|https://maven.apache.org/maven-jsr330.html#how-to-use-jsr-330-in-plugins].
> At the same time the related section of the plugin descriptor
> https://maven.apache.org/ref/3-LATEST/maven-plugin-api/plugin.html#requirement
> should be deprecated as well.
> Compare with the discussion in
> https://lists.apache.org/thread/xfy3wlfxskqw3kmmyj9zxpcj548ft7k8.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
