[ 
https://issues.apache.org/jira/browse/MNG-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874050#comment-17874050
 ] 

ASF GitHub Bot commented on MNG-8210:
-------------------------------------

gnodet commented on code in PR #1651:
URL: https://github.com/apache/maven/pull/1651#discussion_r1718939034


##########
maven-core/src/main/java/org/apache/maven/project/MavenProject.java:
##########
@@ -708,6 +708,9 @@ public List<Plugin> getBuildPlugins() {
     }
 
     public List<String> getModules() {

Review Comment:
   Yes, I was assuming this change targets 4.x api and plugins, so I would not 
care about the v3 api.





> Rename maven module to subproject and make them optional in the POM
> -------------------------------------------------------------------
>
>                 Key: MNG-8210
>                 URL: https://issues.apache.org/jira/browse/MNG-8210
>             Project: Maven
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>            Priority: Major
>             Fix For: 4.0.0-beta-4
>
>
> The maven "module" term is used to actually refer to subproject (since those 
> are loaded as MavenProject, or Project in the v4 api).  The only reference to 
> "module" is in the POM really, so it would make sense to rename to 
> {{subproject}} instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to