cstamas commented on code in PR #313:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/313#discussion_r1733080306
##########
src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java:
##########
@@ -781,9 +781,13 @@ protected static void invokeMaven(
request.setBaseDirectory(projectFile.getParentFile());
request.setPomFile(projectFile);
request.setGlobalSettingsFile(globalSettingsFile);
- request.setUserSettingsFile(userSettingsFile);
+ if (userSettingsFile.isFile()) {
Review Comment:
more needed: UT will NPE as it tests with null value while in
maven-core/embedder this value is never null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
