michael-o commented on code in PR #772: URL: https://github.com/apache/maven-surefire/pull/772#discussion_r1736190235
########## surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java: ########## @@ -172,25 +171,13 @@ private void invokeAllTests(TestsToRun testsToRun, RunListenerAdapter adapter) { } private void execute(TestsToRun testsToRun, RunListenerAdapter adapter) { - if (testsToRun.allowEagerReading()) { - List<DiscoverySelector> selectors = new ArrayList<>(); - testsToRun.iterator().forEachRemaining(c -> selectors.add(selectClass(c.getName()))); - + testsToRun.iterator().forEachRemaining(c -> { LauncherDiscoveryRequestBuilder builder = request() .filters(filters) .configurationParameters(configurationParameters) - .selectors(selectors); - + .selectors(selectClass(c.getName())); launcher.execute(builder.build(), adapter); - } else { Review Comment: I honestly don't know how to proceed because I do not understand the implications :-( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org