[
http://jira.codehaus.org/browse/MSITE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_106179
]
Dennis Lundberg commented on MSITE-209:
---------------------------------------
John, do you think that you could supply a small project hierarchy that
exhibits this issue. It'd help me test your patch.
> populateModulesMenu() logic results in invalid modules list if projects share
> artifactIds
> -----------------------------------------------------------------------------------------
>
> Key: MSITE-209
> URL: http://jira.codehaus.org/browse/MSITE-209
> Project: Maven 2.x Site Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-5, 2.0-beta-6
> Reporter: John Allen
> Priority: Critical
> Attachments: site-patch.diff, site-patch.diff
>
>
> populateModulesMenu() logic should compare groupIds as well as artifactIds.
> Failure to do so can result in invalid modules list being generated when the
> reactorProject.getParent().getArtifectId() is the same as the current project
> but is not of the same group. Logic should be (dont have the code available
> as its on my laptop), oh go on then Ill HTTP the source....
> private void populateModulesMenuItemsFromReactorProjects( Menu menu )
> {
> [SNIP]
> if ( reactorProject != null && reactorProject.getParent() !=
> null &&
> project.getArtifactId().equals(
> reactorProject.getParent().getArtifactId() ) )
> {
> String reactorUrl = reactorProject.getUrl();
> String name = reactorProject.getName();
> appendMenuItem( menu, name, reactorUrl,
> reactorProject.getArtifactId() );
> }
> }
> }
> }
> Comparison should also check that the groupId of the reactorProject's parent
> matches our groupId.
> Clear?.. Sorry, the patch on my laptop too...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
