elharo commented on code in PR #157:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/157#discussion_r1851740306
##########
src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java:
##########
@@ -51,20 +51,23 @@
import org.apache.maven.project.MavenProject;
import org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.component.annotations.Requirement;
-import org.codehaus.plexus.logging.AbstractLogEnabled;
import org.codehaus.plexus.resource.ResourceManager;
import org.codehaus.plexus.resource.loader.FileResourceCreationException;
import org.codehaus.plexus.resource.loader.FileResourceLoader;
import org.codehaus.plexus.resource.loader.ResourceNotFoundException;
import org.codehaus.plexus.util.FileUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* @author Olivier Lamy
* @since 2.5
*
*/
@Component(role = CheckstyleExecutor.class, hint = "default",
instantiationStrategy = "per-lookup")
-public class DefaultCheckstyleExecutor extends AbstractLogEnabled implements
CheckstyleExecutor {
+public class DefaultCheckstyleExecutor implements CheckstyleExecutor {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(DefaultCheckstyleExecutor.class);
Review Comment:
LOGGER is not a named constant and should be logger instead of LOGGER. See
https://stackoverflow.com/questions/1417190/should-a-static-final-logger-be-declared-in-upper-case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
