gnodet commented on code in PR #2024:
URL: https://github.com/apache/maven/pull/2024#discussion_r1905003176
##########
api/maven-api-settings/src/main/mdo/settings.mdo:
##########
@@ -542,9 +542,9 @@
<type>String</type>
<description>
<![CDATA[
- A repository id or (since Maven 2.0.9) an expression matching one
or many repository ids to mirror, e.g.,
+ A repository id or an expression matching one or many repository
ids to mirror, e.g.,
<code>central</code> or <code>*,!repo1</code>.
- <code>*</code> (since Maven 2.0.5), <code>external:*</code> (since
Maven 2.0.9) and <code>external:http:*</code> (since Maven 3.8.0) have
+ <code>*</code>, <code>external:*</code> and
<code>external:http:*</code> (since Maven 3.8.0) have
a special meaning: see <a
href="/guides/mini/guide-mirror-settings.html">Mirror Settings</a> guide.
Review Comment:
Would it make sense to move the documentation in the code rather than
keeping it external ?
It's easier to maintain as using a single PR allows updating both the code
and the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
