CrazyHZM commented on PR #2049:
URL: https://github.com/apache/maven/pull/2049#issuecomment-2598250938

   > There are two references to `new DefaultInterpolator()` that can be easily 
removed:
   > 
   > * 
https://github.com/apache/maven/blob/f5a407cf79494d90ad1df4aa6336239c542d98e1/impl/maven-impl/src/main/java/org/apache/maven/internal/impl/DefaultSettingsBuilder.java#L83-L85
   > * 
https://github.com/apache/maven/blob/f5a407cf79494d90ad1df4aa6336239c542d98e1/impl/maven-impl/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsBuilder.java#L60-L62
   > 
   > We can simply inline those constructors, as they are only used in a few 
tests. This will move the references to the implementation to the tests instead 
of the main code.
   
   @gnodet Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to