[ 
http://jira.codehaus.org/browse/MWAR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_107022
 ] 

Tuomas Kiviaho commented on MWAR-104:
-------------------------------------

Thanks in advance,

I hope this clarifies the remark a bit. Zip overlays a.k.a zip dependencies as 
overlays could be disabled by default for backward compatibility, but enabling 
it isn't in my opinion ideal if there is a zipOverlays=true/false property. 
What about other overlays in the future (tar.gz etc. whatever ArchiveManager 
can handle). There is currently at least 
dependentWarIncludes/dependentWarExcludes configuration parameters suffering 
from similar tight coupling with the packaging in hand. Something like 
overlayTypes="The comma separated list of types to overlay in the WAR. Default 
is 'war'." could be generic enough and gives possibilities to tie 
ArchiveManager in to implementation making overlaying type agnostic.. For me 
choosing the most generic configuration approach in the big picture is more 
important than just having the patch applied, but having a working patch would 
be highly appreciated.

> handle zip dependencies in war plugin
> -------------------------------------
>
>                 Key: MWAR-104
>                 URL: http://jira.codehaus.org/browse/MWAR-104
>             Project: Maven 2.x War Plugin
>          Issue Type: Improvement
>         Environment: all
>            Reporter: Olivier Lamy
>            Assignee: Stephane Nicoll
>             Fix For: 2.1-alpha-1
>
>         Attachments: foobar.zip, MWAR-104
>
>
> As MNG-1683 has been applied, the zip artifact must be handled in the war 
> plugin.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to