elharo commented on code in PR #653: URL: https://github.com/apache/maven-site/pull/653#discussion_r1931408897
########## content/apt/guides/mini/guide-releasing.apt: ########## @@ -235,9 +235,9 @@ checkpoint.prepared-release=OK checkpoint.check-in-development-version=OK ----- - The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root - directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and - by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again. + The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and Review Comment: Something like "Any developer can execute the <<<release:perform>>> goal with the release.properties file to deploy a new instance of the project artifact." ########## content/apt/guides/mini/guide-releasing.apt: ########## @@ -235,9 +235,9 @@ checkpoint.prepared-release=OK checkpoint.check-in-development-version=OK ----- - The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root - directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and - by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again. + The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and + by simply executing the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again. + By default the file gets deleted after a successful release. During the execution of the <<<release:perform>>> goal the entire maven build lifecycle is executed on the project. Review Comment: comma after goal ########## content/apt/guides/mini/guide-releasing.apt: ########## @@ -235,9 +235,9 @@ checkpoint.prepared-release=OK checkpoint.check-in-development-version=OK ----- - The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root - directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and - by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again. + The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and + by simply executing the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again. + By default the file gets deleted after a successful release. During the execution of the <<<release:perform>>> goal the entire maven build lifecycle is executed on the project. The tagged project source code is extracted, compiled, tested, documented and deployed. An instance of the release artifact is deployed Review Comment: comma after documented ########## content/apt/guides/mini/guide-releasing.apt: ########## @@ -235,9 +235,9 @@ checkpoint.prepared-release=OK checkpoint.check-in-development-version=OK ----- - The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root - directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and - by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again. + The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and + by simply executing the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again. + By default the file gets deleted after a successful release. Review Comment: so how is it reused then? I'm missing something here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
