[
https://issues.apache.org/jira/browse/MRESOLVER-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936213#comment-17936213
]
ASF GitHub Bot commented on MRESOLVER-687:
------------------------------------------
gnodet commented on code in PR #671:
URL: https://github.com/apache/maven-resolver/pull/671#discussion_r1998884156
##########
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/validator/Validator.java:
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.spi.validator;
+
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.metadata.Metadata;
+import org.eclipse.aether.repository.LocalRepository;
+import org.eclipse.aether.repository.RemoteRepository;
+
+/**
+ * A repository system main input validator; this validator is used in
repository system "main entry methods".
+ *
+ * @since 2.0.8
+ */
+public interface Validator {
+ /**
+ * Validates artifact.
+ *
+ * @param artifact The artifact to validate, never {@code null}.
+ * @throws IllegalArgumentException if artifact is invalid.
+ */
+ default void isValidArtifact(Artifact artifact) throws
IllegalArgumentException {}
+
+ /**
+ * Validates metadata.
+ *
+ * @param metadata The metadata to validate, never {@code null}.
+ * @throws IllegalArgumentException if artifact is invalid.
+ */
+ default void isValidMetadata(Metadata metadata) throws
IllegalArgumentException {}
+ ;
Review Comment:
Remove the `;`
##########
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/validator/Validator.java:
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.spi.validator;
+
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.metadata.Metadata;
+import org.eclipse.aether.repository.LocalRepository;
+import org.eclipse.aether.repository.RemoteRepository;
+
+/**
+ * A repository system main input validator; this validator is used in
repository system "main entry methods".
+ *
+ * @since 2.0.8
+ */
+public interface Validator {
+ /**
+ * Validates artifact.
+ *
+ * @param artifact The artifact to validate, never {@code null}.
+ * @throws IllegalArgumentException if artifact is invalid.
+ */
+ default void isValidArtifact(Artifact artifact) throws
IllegalArgumentException {}
+
+ /**
+ * Validates metadata.
+ *
+ * @param metadata The metadata to validate, never {@code null}.
+ * @throws IllegalArgumentException if artifact is invalid.
+ */
+ default void isValidMetadata(Metadata metadata) throws
IllegalArgumentException {}
+ ;
+
+ /**
+ * Validates dependency.
+ *
+ * @param dependency The dependency to validate, never {@code null}.
+ * @throws IllegalArgumentException if dependency is invalid.
+ */
+ default void isValidDependency(Dependency dependency) throws
IllegalArgumentException {}
+
+ /**
+ * Validates local repository.
+ *
+ * @param localRepository The local repository to validate, never {@code
null}.
+ * @throws IllegalArgumentException if local repository is invalid.
+ */
+ default void isValidLocalRepository(LocalRepository localRepository)
throws IllegalArgumentException {}
+ ;
Review Comment:
That one too
> Add Artifact/Dependency validation SPI hook
> -------------------------------------------
>
> Key: MRESOLVER-687
> URL: https://issues.apache.org/jira/browse/MRESOLVER-687
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.8
>
>
> Resolver treats GAV strings as opaquen, yet in some cases (ie. dependency
> version set to some non existent property or property with typo) Resolver
> will be asked to resolve that artifact potentially with incomplete
> (uninterpolated) artifact. Resolver will obey (coordinates are opaque) and
> will return "no such artifact".
> This may lead to build error like "non resolvable artifact", while in fact
> user had a typo in version property of a dependency.
> Because resolver has no notion of "interpolation" and "placeholders" (it is
> Maven doing this atop of resolver) a form of callback would be handy where
> Resolver would have an extension point that is implemented in Maven invoked
> before artifact/dependency is about to be resolved where Maven could throw
> early error (not letting Resolver even try to resolve it) as Artifact was
> "incompletely interpolated".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
