gnodet commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028387183
##########
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##########
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns an empty list, which means to apply
a language-dependent pattern.
Review Comment:
What if on windows we have a drive specified ? We need to differentiate:
```
C:/foo/**
```
So maybe rephrase as: `If the pattern does not start with {@code regex:} or
{@code glob:}, the default variation of the {@code glob} pattern will be used.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
