jira-importer commented on issue #224:
URL: 
https://github.com/apache/maven-jar-plugin/issues/224#issuecomment-2956682736

   **[Pawel 
Pastula](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pawelp76)**
 commented
   
   After applying your patch, some tests fail.
   To be precise it's: testVerifyInPlaceSignedJar
   when you invoke:
   mojo.setSignedJar( null );
   you will get NPE in JarSignMojo.java:221:
   addArgIfNotEmpty( arguments, "-signedjar", this.signedjar.getPath() );
   Here is the solution to this problem:
   addArgIfNotEmpty( arguments, "-signedjar", this.signedjar != null ? 
this.signedjar.getPath() : null );
   
   I didn't attach a patch since I don't know to which revision this patch 
should be applied.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to