jira-importer commented on issue #227: URL: https://github.com/apache/maven-jar-plugin/issues/227#issuecomment-2956683366
**[Mike Laurie](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mikelaurie)** commented Wow - thanks Mike; you've been busy! It's good to know the "more than once in the same section" error is already fixed in archiver 2.2. The only thing causing this MJAR issue now seems to be the _possibility_ of including \r and \n characters in manifest header fields. While we're at it, I guess that NUL characters also ought to be quashed since they're the only other invalid attribute chars according to the sun spec. I think these characters should be replaced with spaces as a matter of course. Last question: Does the archiver-plugin take responsibility for this, or should plexus change their jar.Manifest class to replace them? I think plexus should be changed anyway, since it currently allows invalid jar manifests to be created. However, is it worth changing the archiver-plugin to fix the problem now, since it's an easy fix and there needs to be a release soon anyway? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
