jira-importer commented on issue #323: URL: https://github.com/apache/maven-scm/issues/323#issuecomment-2964585667
**[Dennis Lundberg](https://issues.apache.org/jira/secure/[email protected])** commented Where in the code chain would you like this? I looked at the code and found this chain of execution regarding validation of the scmUrl: maven-scm-plugin - ValidateMojo.execute() - ValidateMojo.validateConnection( String connectionString, String type ) maven-scm-api - AbstractScmManager.validateScmRepository( String scmUrl ) - AbstractScmProvider.validateScmUrl( String scmSpecificUrl, char delimiter ) maven-scm-provider - CvsScmProvider.validateScmUrl( String scmSpecificUrl, char delimiter ) / SvnScmProvider.validateScmUrl( String scmSpecificUrl, char delimiter ) - CvsScmProvider.parseScmUrl( String scmSpecificUrl, char delimiter ) / SvnScmProvider.validateScmUrl( String scmSpecificUrl, char delimiter ) The other scm implementations just uses the default implementation available in AbstractScmProvider which makes a call to makeProviderScmRepository( String scmSpecificUrl, char delimiter ) My choice would be to put the resource files inside maven-scm-api somewhere, and put constants defining the error messages in AbstractScmProvider. To make this work we also need a list of possible error codes. Here's something to start with. It's basically a harvesting from the chain above: - Malformed URL - Cannot be null - Must start with "scm" - No such provider - The SCM provider cannot return null from validateScmUrl() - Illegal delimiter - Too few tokens - Too many tokens - Unknown transport (found in cvs provider) - Various "The user_password_host part must be on the form: ..\<specific format>." (found in cvs provider) - Various "A svn '\<protocol>' url must be on the form ...\<specific format>" (found in svn provider) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
